Skip to content

Fix usn-log.json path in build-release-metadata.sh#530

Merged
rkoster merged 1 commit intoubuntu-jammyfrom
fix_usn-log-json_path
Apr 9, 2026
Merged

Fix usn-log.json path in build-release-metadata.sh#530
rkoster merged 1 commit intoubuntu-jammyfrom
fix_usn-log-json_path

Conversation

@neddp
Copy link
Copy Markdown
Member

@neddp neddp commented Apr 9, 2026

Looks like this was a result of the change here - 878080f

publish-ubuntu-jammy pipeline is currently failing: https://bosh.ci.cloudfoundry.org/teams/stemcell/pipelines/ubuntu-jammy-publisher/jobs/publish-ubuntu-jammy-1/builds/58

bosh-stemcells-ci/ci/tasks/build-release-metadata.sh: line 45: usn_log_json_file: unbound variable

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Walkthrough

The Ubuntu-specific USN log download logic in ci/tasks/build-release-metadata.sh was adjusted to fix how the output path is constructed for the meta4 command. The usn_log_json_file variable is now set directly to a concrete path, removing an erroneous nested interpolation segment. The meta4 file-urls and meta4 file-download commands were updated to use the filename usn-log.json as the --file argument instead of the full path variable, while maintaining the same download destination.

Suggested reviewers

  • aramprice
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the usn-log.json path in the build-release-metadata.sh script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly identifies the issue being fixed: an unbound variable error in build-release-metadata.sh caused by a previous change, with a direct reference to the failing pipeline build.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_usn-log-json_path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Apr 9, 2026
@rkoster rkoster requested review from a team, lnguyen and mkocher and removed request for a team April 9, 2026 13:39
@rkoster rkoster moved this from Pending Merge | Prioritized to Pending Review | Discussion in Foundational Infrastructure Working Group Apr 9, 2026
@rkoster rkoster moved this from Pending Review | Discussion to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Apr 9, 2026
Copy link
Copy Markdown

@mike-jc mike-jc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Apr 9, 2026
@rkoster rkoster merged commit d2c8b20 into ubuntu-jammy Apr 9, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants