CI: simplify, consolidate YTT vars file

[aramprice]

• remove un-needed loops in publisher.yml
• remove redundant build_fips field
• harmonize naming between builder.yml and publisher.yml

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3d4a36f4-9ddb-4101-9737-e56d0ea02735

📥 Commits

Reviewing files that changed from the base of the PR and between 7e075fd and 4cb50d5.

📒 Files selected for processing (3)

• ci/pipelines/builder.yml
• ci/pipelines/publisher.yml
• ci/pipelines/vars.yml

---

Walkthrough

The pull request refactors the CI pipeline configuration structure across three files. In builder.yml, occurrences of stemcell_details.os are replaced with stemcell_details.os_short_name for constructing OS-specific resource names and identifiers. In publisher.yml, the pipeline transitions from using separate lts and oss configuration arrays to a consolidated stemcell_details object, updating resource and job naming conventions accordingly. In vars.yml, the top-level lts and oss entries are removed, and the stemcell_details structure is enhanced with new fields (major_version, os_short_name, use_efi) while removing redundant entries.

Suggested reviewers

• mkocher

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main objective of the PR: simplifying and consolidating the YTT vars configuration across CI pipeline files.
Description check	✅ Passed	The description is directly related to the changeset, providing clear bullet points that match the actual changes made to the pipeline files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch simplify-vars-file

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}