Conversation
aramprice
requested review from
a team,
mariash and
neddp
and removed request for
a team
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 24 minutes and 57 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis pull request removes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/fips.md`:
- Line 43: The documented gsutil command is missing the required permission
suffix on the principal; update the line containing "gsutil defacl ch -u
PLACEHOLDER gs://bosh-core-stemcells-fips" to include a permission suffix (for
example ":READER" or ":OWNER") on PLACEHOLDER (e.g., "PLACEHOLDER:READER") so
the command uses the correct principal format and will succeed when run.
In `@docs/new_stemcell_line.md`:
- Around line 11-35: The step "Add, commit, and push the new branch" (the line
with git push --set-upstream origin HEAD) must be moved so it occurs after the
documented edits to ci/pipelines/vars.yml, the update of STEMCELL_LINE in
ci/configure.sh, and after running ./ci/configure.sh; reorder the numbered steps
so editing ci/pipelines/vars.yml, updating STEMCELL_LINE="ubuntu-${short_name}"
in ci/configure.sh and running ./ci/configure.sh come before the add/commit/push
step to keep the workflow consistent.
- Line 8: Remove the stray trailing backtick in the branch creation command
string "git switch -c ubuntu-${short_name} {commit}`" so the line reads without
the backtick; update the command in the docs/new_stemcell_line.md to "git switch
-c ubuntu-${short_name} {commit}" ensuring no extra punctuation remains that
would break copy-paste execution.
In `@docs/publish.md`:
- Around line 11-13: The docs text references the wrong job name; replace the
string "aggregate-candidate-stemcells-1.x" with the actual builder pipeline job
name "aggregate-candidate-stemcells" in the publish.md content so the doc points
to the real job; search for the literal "aggregate-candidate-stemcells-1.x" in
the file and update that occurrence (preserve surrounding sentence and wording).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 982a072e-a8ba-46e6-9bfd-da921d14c565
📒 Files selected for processing (5)
ci/docs/publish.mddocs/develop.mddocs/fips.mddocs/new_stemcell_line.mddocs/publish.md
💤 Files with no reviewable changes (2)
- ci/docs/publish.md
- docs/develop.md
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
docs/fips.md (1)
43-43:⚠️ Potential issue | 🟠 Major
gsutil defaclexample appears invalid without a permission suffixLine 43 likely won’t work as written.
-ugrants typically requireprincipal:PERMISSION(for examplePLACEHOLDER:READER).Suggested fix
-gsutil defacl ch -u PLACEHOLDER gs://bosh-core-stemcells-fips +gsutil defacl ch -u PLACEHOLDER:READER gs://bosh-core-stemcells-fipsCurrent gsutil documentation for `gsutil defacl ch` grant syntax: does `-u` require `<user>:<perm>` (e.g., `:R`/`:READ`)?🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/fips.md` at line 43, The example `gsutil defacl ch -u PLACEHOLDER gs://bosh-core-stemcells-fips` is missing a permission suffix for the principal; update the example so the `-u` argument uses the required principal:PERMISSION form (e.g., replace PLACEHOLDER with a principal followed by a permission such as :READER or :OWNER) so the command demonstrates the correct grant syntax.docs/publish.md (1)
11-13:⚠️ Potential issue | 🟠 MajorUse the actual aggregate job name.
The parenthetical example references
aggregate-candidate-stemcells-1.x, but the builder pipeline job isaggregate-candidate-stemcells(not version-suffixed). Update the text to reflect the actual job name.📝 Proposed fix
-Please check the latest build of the aggregate-candidate-stemcells job of the -stemcell line you need to release (aggregate-candidate-stemcells-1.x), -you should see a successful build which was triggered by the USN notice. +Please check the latest build of the aggregate-candidate-stemcells job of the +stemcell line you need to release, +you should see a successful build which was triggered by the USN notice.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/publish.md` around lines 11 - 13, Update the documentation line that references the job name to use the actual builder pipeline job name "aggregate-candidate-stemcells" instead of the version-suffixed example "aggregate-candidate-stemcells-1.x"; locate the sentence containing that parenthetical and replace the parenthetical with the correct job name so the text reads that you should check the latest build of the aggregate-candidate-stemcells job (no version suffix).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/fips.md`:
- Around line 11-31: Add the required blank lines around the fenced YAML block
and the subsequent headings to satisfy markdownlint rules (MD031/MD022): insert
an empty line before the opening ```yaml fence and after the closing ``` fence,
and ensure there is a blank line between the fenced block and the "## setup
access" heading and between "## setup access" and "### working group actions"
(and similarly before "#### bucket owner actions") so the YAML code block and
each heading are separated by one blank line.
In `@docs/publish.md`:
- Around line 1-2: The markdown headings "# Publish a stemcell." and "## Verify
stemcell builds" need blank lines before and after each heading to comply with
Markdown formatting; update the document so there is an empty line above "#
Publish a stemcell." (if not at top) and an empty line below it, and likewise
ensure a blank line above and below "## Verify stemcell builds" to improve
readability and tool compatibility.
- Around line 17-18: The markdown heading "## Publish stemcells" lacks a blank
line after it; insert a single empty line immediately following the "## Publish
stemcells" heading in docs/publish.md so the heading is separated from the next
paragraph/content and renders correctly.
---
Duplicate comments:
In `@docs/fips.md`:
- Line 43: The example `gsutil defacl ch -u PLACEHOLDER
gs://bosh-core-stemcells-fips` is missing a permission suffix for the principal;
update the example so the `-u` argument uses the required principal:PERMISSION
form (e.g., replace PLACEHOLDER with a principal followed by a permission such
as :READER or :OWNER) so the command demonstrates the correct grant syntax.
In `@docs/publish.md`:
- Around line 11-13: Update the documentation line that references the job name
to use the actual builder pipeline job name "aggregate-candidate-stemcells"
instead of the version-suffixed example "aggregate-candidate-stemcells-1.x";
locate the sentence containing that parenthetical and replace the parenthetical
with the correct job name so the text reads that you should check the latest
build of the aggregate-candidate-stemcells job (no version suffix).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f605394d-42c5-45bc-92b4-4d791a8d828a
📒 Files selected for processing (4)
ci/docs/publish.mddocs/develop.mddocs/fips.mddocs/publish.md
💤 Files with no reviewable changes (2)
- ci/docs/publish.md
- docs/develop.md
- update publish.md - fix markdown in fips.md
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
|
||
| Whenever a USN (Ubuntu Security Notice) is published, a ticket is automatically | ||
| created in the community-stemcell board | ||
| (https://github.com/orgs/cloudfoundry/projects/4). |
There was a problem hiding this comment.
Project #4 does not exist in cloudfoundry (404 error).
|
|
||
| ## Verify stemcell builds | ||
|
|
||
| Whenever a USN (Ubuntu Security Notice) is published, a ticket is automatically |
There was a problem hiding this comment.
Does it mean the stemcell can be published only after USN? If not, I would make the wording clearer
3 participants
Uh oh!
There was an error while loading. Please reload this page.