Skip to content

Use bosh-agent enable-monit-access if available#474

Merged
mariash merged 1 commit intoubuntu-jammyfrom
bosh-monit-access
Feb 25, 2026
Merged

Use bosh-agent enable-monit-access if available#474
mariash merged 1 commit intoubuntu-jammyfrom
bosh-monit-access

Conversation

@mariash
Copy link
Member

@mariash mariash commented Feb 18, 2026

monit-access-helper will use "enable-monit-access" bosh-agent command if it is available and nftables tool is present. Otherwise fall back to old monit cgroup access setup.

This PR requires cloudfoundry/bosh-agent#406

Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the fallback? the stemcell and the agent are in full control here. So we just need to make sure to these changes go out in the same release as the agent. So please remove the check and the fallback.

@github-project-automation github-project-automation bot moved this from Inbox to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Feb 20, 2026
@mariash mariash force-pushed the bosh-monit-access branch 2 times, most recently from 35686fb to 8d3c309 Compare February 25, 2026 00:16
@mariash mariash marked this pull request as ready for review February 25, 2026 01:30
@mariash mariash requested a review from rkoster February 25, 2026 01:30
@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Feb 25, 2026
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there should be some more cleanup like in: https://github.com/cloudfoundry/bosh-linux-stemcell-builder/pull/470/files (on my phone because I'm on vacation) but remember there was some setup for the agent itself which should no longer be used. Only jobs should be calling the helper. Also the monit wrapper should be removed.

@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Feb 25, 2026
aramprice
aramprice previously approved these changes Feb 25, 2026
rkoster
rkoster previously approved these changes Feb 25, 2026
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually: #470 should just be merged first this PR is just a refinement on the other one.

@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Feb 25, 2026
Signed-off-by: Aram Price <aram.price@broadcom.com>
Co-authored-by: Aram Price <aram.price@broadcom.com>
@mariash mariash dismissed stale reviews from rkoster and aramprice via e944ed4 February 25, 2026 18:20
@mariash mariash merged commit 7484ea0 into ubuntu-jammy Feb 25, 2026
3 checks passed
@mariash mariash deleted the bosh-monit-access branch February 25, 2026 18:31
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants