Merged
Conversation
Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the error message in the event rule service to provide a clearer explanation and prevent potential infinite loops.
- Updated the error message to indicate the infinite loop prevention mechanism.
- Adjusted the message formatting to include parameter values explicitly.
Comments suppressed due to low confidence (1)
src/spaceone/monitoring/service/event_rule_service.py:467
- [nitpick] The updated error message is clearer, but consider enclosing variable names in backticks or similar delimiters to improve readability and ensure consistency with other error messages.
reason=f"To avoid an infinite loop, the change_project_id({change_project_id}) in the action must differ from the project_id in the event rule.",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue