Add recursive action checks and pagination limit for event rules#138
Add recursive action checks and pagination limit for event rules#138ImMin5 merged 2 commits intocloudforet-io:masterfrom
Conversation
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
1 similar comment
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in event rule processing by adding recursive validations for action rules and limits alert query pagination while cleaning up leftover debug statements.
- Added recursive action validation checks in event_rule_service.py
- Applied a pagination limit of 1000 in alert_service.py
- Removed a debugging print statement in alert_manager.py and refactored a minor formatting change in event_rule_manager.py
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/spaceone/monitoring/service/event_rule_service.py | Added recursive action checks for event rule validations |
| src/spaceone/monitoring/service/alert_service.py | Applied a pagination limit decorator and introduced a new import |
| src/spaceone/monitoring/manager/event_rule_manager.py | Introduced a new filter_event_rules method with minor formatting adjustments |
| src/spaceone/monitoring/manager/alert_manager.py | Removed a debug print statement |
Comments suppressed due to low confidence (2)
src/spaceone/monitoring/manager/alert_manager.py:28
- Remove the debugging print statement to avoid unintended logging in production.
print(params)
src/spaceone/monitoring/service/alert_service.py:4
- The import 'page_size_length' is not used in the current diff. Consider removing it to reduce unnecessary dependencies.
from pandas.io.sas.sas_constants import page_size_length
Category
Description
Known issue