Skip to content

Fixing bug when two containers share same image#13044

Open
mikenomitch wants to merge 1 commit intomainfrom
nomitch/multi-container-sharing-image
Open

Fixing bug when two containers share same image#13044
mikenomitch wants to merge 1 commit intomainfrom
nomitch/multi-container-sharing-image

Conversation

@mikenomitch
Copy link
Copy Markdown
Contributor

@mikenomitch mikenomitch commented Mar 24, 2026

Fixes issue when two container apps share the same image one is not found.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

🦋 Changeset detected

Latest commit: 775578b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 24, 2026

The logic is correct and clean. The old code would incorrectly remove tags like cloudflare-dev/other-class:some-build-id when cleaning up for cloudflare-dev/my-class:current-build-id, since both start with cloudflare-dev. The new code properly scopes removal to only tags sharing the same cloudflare-dev/<classname> repository prefix.

There are no tests for this function currently, and the PR doesn't add any, but the changeset bot already flagged the missing changeset. The code change itself is sound.

LGTM

github run

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13044

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13044

miniflare

npm i https://pkg.pr.new/miniflare@13044

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13044

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13044

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13044

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13044

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13044

wrangler

npm i https://pkg.pr.new/wrangler@13044

commit: 775578b

@mikenomitch mikenomitch force-pushed the nomitch/multi-container-sharing-image branch from 6c5c4ba to cf3d19d Compare April 20, 2026 19:29
@mikenomitch mikenomitch marked this pull request as ready for review April 20, 2026 19:30
@mikenomitch mikenomitch self-assigned this Apr 20, 2026
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team April 20, 2026 19:30
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 20, 2026

Codeowners approval required for this PR:

  • @cloudflare/cloudchamber
  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/containers-shared/src/utils.ts: [@cloudflare/cloudchamber @cloudflare/wrangler]
  • packages/containers-shared/tests/utils.test.ts: [@cloudflare/cloudchamber @cloudflare/wrangler]

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@mikenomitch mikenomitch force-pushed the nomitch/multi-container-sharing-image branch from cf3d19d to 775578b Compare April 20, 2026 19:49
@mikenomitch mikenomitch requested a review from aron-cf April 20, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants