feat(cli): add lockfile support to pywrangler sync command#108
feat(cli): add lockfile support to pywrangler sync command#108ryanking13 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds lockfile support (pylock.toml) to pywrangler sync, using uv pip compile to pin dependency versions and a new --upgrade flag to refresh them. Overall the approach is sound. A couple of issues below.
_read_lockfile_requirementswill crash with an opaqueKeyErroron malformed lockfile entries (medium severity)- Private function
_get_lockfile_pathis imported across module boundaries (low severity)
|
Review posted on PR #108. Two issues flagged:
|
`pywrangler sync` command now generates a `pylock.toml` file that locks the installed packages. Rerunning `pywrangler sync` now keep the existing installed versions and will not upgrade packages silently. Also added `--upgrade` flag to `pywrangler sync` which upgrades the packages in the lockfile.
2d04385 to
e71384d
Compare
pywrangler sync will now generate a
pylock.tomlfile that locks the installed packages. Rerunning pywrangler sync will now keep the existing installed versions and will not upgrade packages silently.Also added
--upgradeflag to pywrangler sync which upgrades the packages in the lockfile.