feat(y-partyserver): add compatibility with yjs 14.x#305
Open
agcty wants to merge 2 commits intocloudflare:mainfrom
Open
feat(y-partyserver): add compatibility with yjs 14.x#305agcty wants to merge 2 commits intocloudflare:mainfrom
agcty wants to merge 2 commits intocloudflare:mainfrom
Conversation
This change adds support for yjs 14.x (beta) while maintaining backwards compatibility with yjs 13.x. Changes: - Updated peerDependencies to accept both yjs ^13.6.14 and ^14.0.0-0 - Added documentation explaining version differences - Updated @ts-expect-error to @ts-ignore for cross-version compatibility - Added YSharedType type alias for version-agnostic type references Key differences between yjs 13 and 14: - AbstractType generic signature changed from <EventType> to <EventDelta, Self> - Stricter type constraints (T extends YValue) in yjs 14 - doc.share type changed from Map<string, AbstractType<YEvent<any>>> to Map<string, YType> - Event handler signatures have additional parameters in yjs 14 All changes are type-level only; runtime behavior is unchanged.
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
@threepointone changed to ts-expect-error |
Collaborator
|
@agcty lol thank you, but I'm trying to get this opencode integration working and trying it out haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for yjs 14.x (beta) while maintaining backwards compatibility with yjs 13.x.
Changes
peerDependenciesto accept bothyjs ^13.6.14and^14.0.0-0@ts-expect-errorto@ts-ignorefor cross-version type compatibilityBackground
yjs 14.x introduces several TypeScript-level breaking changes:
AbstractTypegeneric<EventType><EventDelta, Self>with constraintsT extends YValue)doc.sharetypeMap<string, AbstractType<YEvent<any>>>Map<string, YType>transaction)All changes are type-level only - runtime behavior is unchanged. The sync protocol and CRDT encoding remain compatible between versions.
Testing
Related
This allows projects using yjs 14 beta to use y-partyserver without npm override hacks.
🤖 Generated with Claude Code