chore: auto formatter#31018
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
pnpm run format:check currently fails. 3 issues need fixing before merge.
- CRITICAL:
pnpm run format:checkfails on 8 files — 7 MDX files merged fromproductionare unformatted, and.opencode/package.jsonis not ignored. Runpnpm run formatand add.opencode/to.prettierignore. - HIGH:
Example.astroandPageTitle.astroconvert conditional<style>blocks to<style set:html>. This removes Astro's default style scoping, making those styles global. Verify this is intentional. - MEDIUM: ~60 files in
.prettierignoreunder "Deferred follow-up work" lack a tracking issue or plan. The previous ignore list referencedFORMATTING-PLAN.md, which no longer exists. Consider creating a follow-up issue to track these.
|
Labels applied: docs engine, documentation. SummaryPR #31018 adopts Prettier formatting across the MD/MDX/Astro content tree. It:
Issues flaggedI posted a review with 4 inline comments. Key issues requiring maintainer attention:
No commits were pushed. |
|
/bonk review |
There was a problem hiding this comment.
Previous issues addressed: CI enforcement reverted, Example.astro and PageTitle.astro restored to scoped <style> blocks. 2 new issues need fixing before merge.
CRITICAL: .opencode/ missing from .prettierignore
pnpm run format:data attempts to format generated files under .opencode/ (e.g., .opencode/package.json). These files should be ignored.
HIGH: Unnecessary "Deferred follow-up work" entries
I batch-checked every file in this section — Example.astro, PageTitle.astro, and all 65 MDX files — and Prettier parses and formats every one of them correctly. None need to be ignored. Remove the entire block so future edits are checked.
No build, type, lint, or test regressions found.
|
Posted a review on PR #31018 with 2 inline comments. What I found
New issues flagged
Review link: #31018 (review) |
|
Preview URL: https://e8371d53.preview.developers.cloudflare.com |
|
/bonk review |
There was a problem hiding this comment.
Fixed the remaining .opencode/ ignore issue. No other blockers found.
CRITICAL (fixed): Added .opencode/ to .prettierignore to prevent format:data from touching generated agent files.
Validation passed:
pnpm run check✅pnpm run lint✅pnpm run format:core:check✅pnpm run test:prebuild✅
Co-authored-by: MohamedH1998 <MohamedH1998@users.noreply.github.com>
|
Posted a review on PR #31018. What changed
ValidationAll checks pass after the fix:
No other issues found. Ready for merge once the auto-push completes. |
Summary
Adopts Prettier formatting across the MD/MDX/Astro content tree
Screenshots (optional)
Documentation checklist