chore: standardize Node/npm version handling#29578
Merged
mvvmm merged 3 commits intoproductionfrom Apr 6, 2026
Merged
Conversation
… workflows - Add node version to cache keys across all workflows to prevent cache conflicts between Node versions - Standardize node-version to 24.x format and add step IDs for version output - Replace engines with devEngines for better package manager enforcement - Update .nvmrc to use major version only (24) - Remove engine-strict from .npmrc - Add lockfiles from other package managers to .gitignore
mvvmm
requested review from
a team,
MohamedH1998,
ahaywood,
colbywhite and
kodster28
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
kodster28
approved these changes
Apr 3, 2026
Contributor
|
Preview URL: https://d2434df8.preview.developers.cloudflare.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
engineswithdevEngines, and removeengine-strictfrom.npmrcdevEnginesis our new indication to contributors about which node version and package managers we use, and is only enforced bynpmand when usingcorepack(default in node v24), so it doesn't block folks from using other package managers. When usingnpmthough, this enforces the node v > 24 and npm v > 11, which is the level of enforcement we want.Add
preinstallscript that errors if not usingnpmand dd lockfiles from other package managers to.gitignore.Add node version to cache keys across all workflows to prevent cache conflicts between Node versions
Standardize node-version to
24.xformat and add step IDs for version outputUpdate
.nvmrcto use major version only (24)devEnginesand CI