Document sleepAfter bug fix (sandbox-sdk#323) #27375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note to sandbox-options.mdx explaining that the sleepAfter option passed to getSandbox() now works correctly as documented. Prior to v0.2.17, this option was ignored due to a timing issue where the Container constructor called renewActivityTimeout() with the default before the RPC call to setSleepAfter() could run. Related: cloudflare/sandbox-sdk#323
agents-git-bot
bot
requested review from
a team,
ghostwriternr and
whoiskatrin
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://ed17a5e9.preview.developers.cloudflare.com Files with changes (up to 15)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documents the bug fix from cloudflare/sandbox-sdk#323 where the
sleepAfteroption passed togetSandbox()was being ignored.Changes
sleepAftersection in sandbox-options.mdx explaining that this option now works correctly as documented in v0.2.17Related PR
Type of documentation update
Bug fix clarification - informing users that a previously documented feature now works correctly.