Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MlKemParamsis anenum, which means it's fully public, and can't have any private fields to store any other params in the future. These two data-less variants it's all it can have.MlKemdoesn't have its own state other than the params. Given that the params are trivial and non-extensible, this makesMlKem::new(params)pretend to be more than it can be. It's not constructing any object, it's just indirection for the params (callingffi::init()is handled by keys' functions anyway).So I've made
MlKemParamsandMlKemthe same thing.mlkem::MlKem::MlKem768is repetitive, so I've renamedMlKem(Params)toAlgorithm. It can be used asmlkem::Algorithmwhere the context is needed.