-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Add --scan-dryrun-results flag for Maven test runner #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
psakthivel04
wants to merge
1
commit into
v1
Choose a base branch
from
feat/scan-dryrun-results
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Maven Test Data | ||
|
|
||
| This directory contains test fixtures for the Maven test runner, including sample Maven Surefire reports used to test the `--scan-dryrun-results` feature. | ||
|
|
||
| ## Directory Structure | ||
|
|
||
| - `dryrun-test/` - Test data for the `--scan-dryrun-results` feature | ||
| - `target/surefire-reports/` - Sample Maven Surefire reports (XML and TXT formats) | ||
| - `reports/` - Sample test result XML files for various test scenarios | ||
|
|
||
| ## How to Test Manually with Your Own Project | ||
|
|
||
| To manually test the `--scan-dryrun-results` feature with your own Maven project: | ||
|
|
||
| ```bash | ||
| # 1. Navigate to your Maven project | ||
| cd /path/to/your/maven-project | ||
|
|
||
| # 2. Run Maven dry-run to generate reports | ||
| mvn test -DdryRun=true | ||
|
|
||
| # 3. Verify reports were created | ||
| ls -la target/surefire-reports/TEST-*.xml | ||
|
|
||
| # 4. Set up environment (if not already set) | ||
| export LAUNCHABLE_TOKEN='v1:your-org/your-workspace:your-actual-token' | ||
|
|
||
| # 5. Record build | ||
| launchable record build --name 'test-build-name' | ||
|
|
||
| # 6. Create a session | ||
| launchable record session --build 'test-build-name' | ||
| # Copy the session ID from output, e.g., builds/test-build-name/test_sessions/123 | ||
|
|
||
| # 7. Run subset with --scan-dryrun-results | ||
| launchable subset maven \ | ||
| --scan-dryrun-results \ | ||
| --session builds/test-build-name/test_sessions/123 \ | ||
| --target 10% | ||
| ``` | ||
|
|
||
| ## Creating Test Files for `--scan-dryrun-results` | ||
|
|
||
| The test files in `dryrun-test/target/surefire-reports/` are fixtures that simulate Maven Surefire reports generated by running tests with Maven's dry-run mode. | ||
|
|
||
| ### How to Create/Update These Files | ||
|
|
||
| To create or update test fixture files, run Maven tests from within the `dryrun-test` directory: | ||
|
|
||
| ```bash | ||
| cd tests/data/maven/dryrun-test | ||
|
|
||
| # Run Maven dry-run to generate Surefire reports | ||
| mvn test -DdryRun=true | ||
|
|
||
| # The reports will be automatically generated in target/surefire-reports/ | ||
| # - XML files: TEST-*.xml (detailed test execution results) | ||
| # - TXT files: *.txt (summary information for each test class) | ||
| ``` | ||
|
|
||
| The generated reports in `target/surefire-reports/` are used directly as test fixtures. | ||
|
|
||
| ### Purpose | ||
|
|
||
| These fixtures are used to test: | ||
| - Parsing of Maven Surefire XML reports | ||
| - The `--scan-dryrun-results` flag functionality | ||
| - Integration with Launchable's subset API | ||
| - Handling of filtered/excluded tests | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it correct? pom.xml file and other files don't exist. And I've faced this error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes without pom.xml . will get this error. This is fine right.