Skip to content

[LCHIB-659] HEAD commit should be always collected. #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kohsuke merged 2 commits into from
Nov 13, 2025
Merged

[LCHIB-659] HEAD commit should be always collected. #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37803e7
[LCHIB-659] HEAD commit should be always collected.
kohsuke Nov 12, 2025
fbc5ed8
Merge remote-tracking branch 'origin/v1' into LCHIB-659
kohsuke Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified launchable/jar/exe_deploy.jar
View file
Open in desktop
Binary file not shown.
8 changes: 6 additions & 2 deletions src/main/java/com/launchableinc/ingest/commits/CommitGraphCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,10 +434,14 @@ public void transfer(Collection<ObjectId> advertised, Consumer<JSCommit> commitR
// and it drastically cuts down the initial commit consumption of a new large repository.
// ... except we do want to capture the head commit, as that makes it easier to spot integration problems
// when `record build` and `record commit` are separated.

// two RevFilters are order sensitive. This is because CommitTimeRevFilter.after doesn't return false to
// filter things out, it throws StopWalkException to terminate the walk, never giving a chance for the other
// branch of OR to be evaluated. So we need to put ObjectRevFilter first.
walk.setRevFilter(
OrRevFilter.create(
CommitTimeRevFilter.after(System.currentTimeMillis() - TimeUnit.DAYS.toMillis(maxDays)),
new ObjectRevFilter(headId)));
new ObjectRevFilter(headId),
CommitTimeRevFilter.after(System.currentTimeMillis() - TimeUnit.DAYS.toMillis(maxDays))));

for (ObjectId id : advertised) {
try {
Expand Down
Loading