Skip to content

Remove a useless test - HttpClientTest#test_reason #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ono-max merged 1 commit into from
Sep 16, 2025
Merged

Remove a useless test - HttpClientTest#test_reason #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions tests/utils/test_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
import platform
from unittest import TestCase, mock

from requests import Session

from launchable.utils.http_client import _HttpClient
from launchable.version import __version__

Expand Down Expand Up @@ -45,19 +43,3 @@ def test_header(self):
"dummy",
),
})

def test_reason(self):
'''make sure we correctly propagate error message from the server'''

# use new session to disable retry
cli = _HttpClient(session=Session())
# /raise_error is an actual endpoint that exists on our service to test the behavior
res = cli.request("GET", "intake/raise_error")
self.assertEqual(res.status_code, 500)
self.assertEqual(res.reason, "Welp")

try:
res.raise_for_status()
self.fail("should have raised")
except Exception as e:
self.assertIn("Welp", str(e))
Loading