Skip to content

Conversation

@ono-max
Copy link
Contributor

@ono-max ono-max commented Sep 10, 2025

$ launchable record session --build 210 --test-suite foo
builds/210/test_sessions/289
$ launchable record tests --allow-test-before-build file test-results/*.xml
Launchable recorded tests for build 210 (test session 289) to workspace launchableinc/mothership from 1 files:

|   Files found |   Tests found |   Tests passed |   Tests failed |   Total duration (min) |
|---------------|---------------|----------------|----------------|------------------------|
|             1 |             2 |              2 |              0 |                   0.00 |

Visit https://app.launchableinc.com/organizations/launchableinc/workspaces/mothership/test-sessions/289 to view uploaded test results (or run `launchable inspect tests --test-session-id 289`)
$ launchable retry flake-detection --session 'builds/210/test_sessions/289' --confidence low file
file=tests/test_version.py                                                                                       

@ono-max ono-max marked this pull request as ready for review September 10, 2025 05:58
@launchable-app

This comment has been minimized.

split_subset = launchable.CommonSplitSubsetImpls(__name__,
formatter=lambda x: x[0]['name'] + ":" + x[1]['name']).split_subset()

launchable.CommonFlakeDetectionImpls(__name__, formatter=lambda x: x[0]['name'] + ":" + x[1]['name']).flake_detection()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information:
Why do we need it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To register this test runner as the command. By adding that line, we can do something like this:

$ launchable retry flake-detection --session 'builds/210/test_sessions/289' --confidence low bazel

@gayanW
Copy link
Contributor

gayanW commented Sep 10, 2025

FYI:
The PR is created for the main and not the v1 branch.

@ono-max
Copy link
Contributor Author

ono-max commented Sep 10, 2025

FYI: The PR is created for the main and not the v1 branch.

Oh, good catch. Thanks!

@ono-max ono-max changed the base branch from main to v1 September 10, 2025 07:34
@ono-max ono-max merged commit d04c2f3 into v1 Sep 10, 2025
13 checks passed
@ono-max ono-max deleted the flake-detection branch September 10, 2025 21:50
Konboi added a commit that referenced this pull request Sep 22, 2025
Konboi added a commit that referenced this pull request Sep 22, 2025
to align v2 command option formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants