Skip to content

Support subtest case in go-test profile #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Konboi merged 2 commits into from
Jun 17, 2025
Merged

Support subtest case in go-test profile #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e2c93
support subtest case
Konboi Jun 16, 2025
9be5e1b
update test data
Konboi Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions launchable/test_runners/go_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,23 @@ def record_tests(client, source_roots):
def path_builder(case: TestCase, suite: TestSuite, report_file: str) -> TestPath:
tp = default_path_builder(case, suite, report_file)
for tpc in tp:
if 'type' in tpc and 'name' in tpc and tpc['type'] == 'class':
# go-junit-report v2 reports full package name. go-junit-report
# v1 reports only the last component of the package name. In
# order to make this backward compatible, we align this to v1.
tpc['name'] = tpc['name'].split('/')[-1]
if 'type' in tpc and 'name' in tpc:
if tpc['type'] == 'class':
# go-junit-report v2 reports full package name. go-junit-report
# v1 reports only the last component of the package name. In
# order to make this backward compatible, we align this to v1.
tpc['name'] = tpc['name'].split('/')[-1]
if tpc['type'] == 'testcase' and '/' in tpc['name']:
# go-junit-report produces test with subtests like `<TEST NAME?/<SUBTEST NAME>`
# But `go test -list` command doesn't include subtest names
# So, we split the name by '/' and save testcase and subtest
names = tpc['name'].split('/')
tpc['name'] = names[0]
tp.append({
'type': 'subtest',
'name': '/'.join(names[1:]) if len(names) > 1 else ''
})

return tp

client.path_builder = path_builder
Expand Down
110 changes: 104 additions & 6 deletions tests/data/go_test/record_test_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"testPath": [
{
"type": "class",
"name": "rocket-car-gotest"
"name": "go"
},
{
"type": "testcase",
Expand All @@ -23,7 +23,7 @@
"testPath": [
{
"type": "class",
"name": "rocket-car-gotest"
"name": "go"
},
{
"type": "testcase",
Expand All @@ -41,7 +41,7 @@
"testPath": [
{
"type": "class",
"name": "rocket-car-gotest"
"name": "go"
},
{
"type": "testcase",
Expand All @@ -59,7 +59,7 @@
"testPath": [
{
"type": "class",
"name": "rocket-car-gotest"
"name": "go"
},
{
"type": "testcase",
Expand All @@ -71,11 +71,109 @@
"stdout": "",
"stderr": "",
"data": null
},
{
"type": "case",
"testPath": [
{
"type": "class",
"name": "go"
},
{
"type": "testcase",
"name": "TestExample5"
}
],
"duration": 0.0,
"status": 1,
"stdout": "",
"stderr": "",
"data": null
},
{
"type": "case",
"testPath": [
{
"type": "class",
"name": "go"
},
{
"type": "testcase",
"name": "TestExample5"
},
{
"type": "subtest",
"name": "Test_case_1"
}
],
"duration": 0.0,
"status": 1,
"stdout": "",
"stderr": "",
"data": null
},
{
"type": "case",
"testPath": [
{
"type": "class",
"name": "go"
},
{
"type": "testcase",
"name": "TestExample5"
},
{
"type": "subtest",
"name": "Test_case_2_(fail_case)"
}
],
"duration": 0.0,
"status": 1,
"stdout": "",
"stderr": "",
"data": null
},
{
"type": "case",
"testPath": [
{
"type": "class",
"name": "example"
},
{
"type": "testcase",
"name": "TestGreeting"
}
],
"duration": 0.0,
"status": 1,
"stdout": "",
"stderr": "",
"data": null
},
{
"type": "case",
"testPath": [
{
"type": "class",
"name": "example"
},
{
"type": "testcase",
"name": "ExampleGreeting"
}
],
"duration": 0.0,
"status": 1,
"stdout": "",
"stderr": "",
"data": null
}
],
"testRunner": "go-test",
"group": "",
"noBuild": false,
"flavors": [],
"testSuite": ""
"testSuite": "",
"flavors": {}
}
22 changes: 16 additions & 6 deletions tests/data/go_test/reportv1/reportv1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite tests="4" failures="0" time="5.262" name="github.com/launchableinc/rocket-car-gotest">
<testsuite tests="7" failures="0" time="0.000" name="github.com/launchableinc/examples/go">
<properties>
<property name="go.version" value="go1.15.5"></property>
<property name="go.version" value="go1.24.2"></property>
</properties>
<testcase classname="rocket-car-gotest" name="TestExample1" time="0.000"></testcase>
<testcase classname="rocket-car-gotest" name="TestExample2" time="3.000"></testcase>
<testcase classname="rocket-car-gotest" name="TestExample3" time="0.000"></testcase>
<testcase classname="rocket-car-gotest" name="TestExample4" time="2.000"></testcase>
<testcase classname="go" name="TestExample1" time="0.000"></testcase>
<testcase classname="go" name="TestExample2" time="3.000"></testcase>
<testcase classname="go" name="TestExample3" time="0.000"></testcase>
<testcase classname="go" name="TestExample4" time="2.000"></testcase>
<testcase classname="go" name="TestExample5" time="0.000"></testcase>
<testcase classname="go" name="TestExample5/Test_case_1" time="0.000"></testcase>
<testcase classname="go" name="TestExample5/Test_case_2_(fail_case)" time="0.000"></testcase>
</testsuite>
<testsuite tests="2" failures="0" time="0.000" name="github.com/launchableinc/examples/go/example">
<properties>
<property name="go.version" value="go1.24.2"></property>
</properties>
<testcase classname="example" name="TestGreeting" time="0.000"></testcase>
<testcase classname="example" name="ExampleGreeting" time="0.000"></testcase>
</testsuite>
</testsuites>
21 changes: 14 additions & 7 deletions tests/data/go_test/reportv2/reportv2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites tests="6">
<testsuite name="github.com/launchableinc/rocket-car-gotest" tests="4" failures="0" errors="0" id="0" hostname="dummy" time="5.000" timestamp="2022-08-24T11:23:46+09:00">
<testcase name="TestExample1" classname="github.com/launchableinc/rocket-car-gotest" time="0.000"></testcase>
<testcase name="TestExample2" classname="github.com/launchableinc/rocket-car-gotest" time="3.000"></testcase>
<testcase name="TestExample3" classname="github.com/launchableinc/rocket-car-gotest" time="0.000"></testcase>
<testcase name="TestExample4" classname="github.com/launchableinc/rocket-car-gotest" time="2.000"></testcase>
</testsuite>
<testsuites tests="9">
<testsuite name="github.com/launchableinc/examples/go" tests="7" failures="0" errors="0" id="0" hostname="MAC-ryabuki.local" time="5.000" timestamp="2025-06-16T16:31:58+09:00">
<testcase name="TestExample1" classname="github.com/launchableinc/examples/go" time="0.000"></testcase>
<testcase name="TestExample2" classname="github.com/launchableinc/examples/go" time="3.000"></testcase>
<testcase name="TestExample3" classname="github.com/launchableinc/examples/go" time="0.000"></testcase>
<testcase name="TestExample4" classname="github.com/launchableinc/examples/go" time="2.000"></testcase>
<testcase name="TestExample5" classname="github.com/launchableinc/examples/go" time="0.000"></testcase>
<testcase name="TestExample5/Test_case_1" classname="github.com/launchableinc/examples/go" time="0.000"></testcase>
<testcase name="TestExample5/Test_case_2_(fail_case)" classname="github.com/launchableinc/examples/go" time="0.000"></testcase>
</testsuite>
<testsuite name="github.com/launchableinc/examples/go/example" tests="2" failures="0" errors="0" id="1" hostname="MAC-ryabuki.local" time="0.000" timestamp="2025-06-16T16:31:58+09:00">
<testcase name="TestGreeting" classname="github.com/launchableinc/examples/go/example" time="0.000"></testcase>
<testcase name="ExampleGreeting" classname="github.com/launchableinc/examples/go/example" time="0.000"></testcase>
</testsuite>
</testsuites>
Loading