resolve VirtIO osVersion once in Get-VirtIODrivers#419
Open
mpanduru wants to merge 1 commit intocloudbase:masterfrom
Open
resolve VirtIO osVersion once in Get-VirtIODrivers#419mpanduru wants to merge 1 commit intocloudbase:masterfrom
mpanduru wants to merge 1 commit intocloudbase:masterfrom
Conversation
mpanduru
force-pushed
the
refactor_virtio_mapping
branch
from
5fc3edd to
518b500
Compare
Contributor
Author
|
Tested with virtio 0.1.285 and Windows Server 2022. |
ader1990
reviewed
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation resolves the matching osVersion inside the per-driver loop, which means we iterate over the OS mapping table for every driver even though the mapping does not depend on the driver, which creates unnecessary iterations.
This change computes the osVersion once up front and then uses that resolved version to build and validate the driver paths, keeping the same behavior.