fix: remove invalid Unlock calls in scaleset worker#598
Open
benoit-nexthop wants to merge 1 commit intocloudbase:mainfrom
Open
fix: remove invalid Unlock calls in scaleset worker#598benoit-nexthop wants to merge 1 commit intocloudbase:mainfrom
benoit-nexthop wants to merge 1 commit intocloudbase:mainfrom
Conversation
- Remove Unlock call in handleScaleDown that was called before any lock was acquired - Change defer Unlock to immediate Unlock in consolidateRunnerState loop to avoid holding locks until function exit
This was referenced Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes invalid mutex unlock calls in the scaleset worker that could cause panics.
Changes
Unlockcall inhandleScaleDownthat was called before any lock was acquireddefer Unlockto immediateUnlockinconsolidateRunnerStateloop to avoid holding locks until function exitTesting
Tested in production environment.
This PR is part of a stack of changes: