Add windows osmorphing method to remove uninstall entry#384
Open
Cristi1324 wants to merge 2 commits intocloudbase:masterfrom
Open
Add windows osmorphing method to remove uninstall entry#384Cristi1324 wants to merge 2 commits intocloudbase:masterfrom
Cristi1324 wants to merge 2 commits intocloudbase:masterfrom
Conversation
Dany9966
reviewed
Jan 21, 2026
Dany9966
approved these changes
Jan 21, 2026
Dany9966
reviewed
Feb 13, 2026
coriolis/osmorphing/windows.py
Outdated
| ignore_stdout=True, | ||
| ) | ||
|
|
||
| def _delete_unistall_entry(self, key_name, service_name): |
Contributor
There was a problem hiding this comment.
NIT: Please fix the name of the method:
_delete_uninstall_entry (typo).
379c905 to
e334493
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.