Skip to content

Use blob responseType for log downloads to prevent memory issues #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dany9966 merged 2 commits into from
Feb 19, 2026
Merged

Use blob responseType for log downloads to prevent memory issues #865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c380dc0
Use `blob` `responseType` for log downloads to prevent memory issues
mihaelabalutoiu Feb 5, 2026
4826d78
Add error handling for `downloadAll` method to handle large downloads
mihaelabalutoiu Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 32 additions & 22 deletions src/stores/LogStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,28 +90,38 @@ class LogStore {

@action async downloadAll(startDate?: Date | null, endDate?: Date | null) {
this.downloadingAllLogs = true;
await ObjectUtils.waitFor(() => this.logs.length > 0);
const logFilesResponses = await Promise.all(
this.logs.map(async log => ({
name: log.log_name,
content: await apiCaller.send({
url: generateUrlForLog(log.log_name, startDate, endDate),
}),
})),
);
const zip = new JSZip();
logFilesResponses.forEach(response => {
zip.file(`${response.name}.log`, response.content.data);
});
await downloadDiagnosticsIntoZip(zip);
const zipContent = await zip.generateAsync({
type: "blob",
compression: "DEFLATE",
});
saveAs(zipContent, "logs.zip");
runInAction(() => {
this.downloadingAllLogs = false;
});
try {
await ObjectUtils.waitFor(() => this.logs.length > 0);
const logFilesResponses = await Promise.all(
this.logs.map(async log => ({
name: log.log_name,
content: await apiCaller.send({
url: generateUrlForLog(log.log_name, startDate, endDate),
responseType: "blob",
}),
})),
);
const zip = new JSZip();
logFilesResponses.forEach(response => {
zip.file(`${response.name}.log`, response.content.data);
});
await downloadDiagnosticsIntoZip(zip);
const zipContent = await zip.generateAsync({
type: "blob",
compression: "DEFLATE",
});
saveAs(zipContent, "logs.zip");
} catch (err) {
console.error("Download all logs failed:", err);
notificationStore.alert(
`Download failed: ${String(err)}. Please try again with a smaller time range.`,
"error",
);
} finally {
runInAction(() => {
this.downloadingAllLogs = false;
});
}
}

@action download(
Expand Down