Fix confirmed reads test flake#5237
Open
joshua-spacetime wants to merge 3 commits into
Open
Conversation
`test_confirmed_reads` no longer asserts on `Poll::Pending` or `Poll::Ready`. Strict gating behavior is already covered by the `ClientConnectionReceiver` tests. The actor test now only verifies that messages arrive after durability advances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously
assert_after_durableassumed thatPoll::Pendingmeant confirmed reads was blocked on durability. That was not necessarily true, because subscription messages pass through the subscription send worker before reaching the client receiver. APoll::Pendingcould also mean the send worker had not delivered the message yet, so a single immediate poll after marking durability was not guaranteed to bePoll::Ready.This patch removes
test_confirmed_readsentirely since the guarantee that client receivers do not receive messages before they are durable is already covered by theClientConnectionReceivertests, wherePendingis unambiguous.API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
N/A