Batch websocket responses using the v3 protocol#5061
Open
joshua-spacetime wants to merge 2 commits into
Open
Conversation
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
c5c3d1a to
0972b81
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
31e54ca to
fa60dfa
Compare
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
0972b81 to
2926736
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
fa60dfa to
7f11e8b
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
2 times, most recently
from
d6cc30a to
abcec19
Compare
Comment on lines
-207
to
+208
| #[help = "The size of messages sent to connected sessions"] | ||
| #[labels(db: Identity, workload: WorkloadType)] | ||
| #[help = "The size of websocket payloads sent to connected sessions"] | ||
| #[labels(db: Identity)] |
Contributor
Author
There was a problem hiding this comment.
It doesn't make sense to label these metrics by workload if we are sending multiple messages from potentially multiple workloads in a single payload. I'm calling this change out in case we're using this metric for billing.
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
d318465 to
af242c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In keeping with the "pipeline everything" approach of SpacetimeDB, this patch serializes multiple client updates in a single websocket message using the v3 protocol.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
My preference would be to teach
spacetime subscribeto talk v2/v3 in order to get adequate coverage via the smoketests.