Extract replay stuff out of CommittedState, part 1#4804
Open
Extract replay stuff out of CommittedState, part 1#4804
CommittedState, part 1#4804Conversation
gefjon
approved these changes
Apr 14, 2026
| impl MemoryUsage for ReplayCommittedState<'_> { | ||
| fn heap_usage(&self) -> usize { | ||
| let Self { | ||
| state: _, // We don't attribute usage to `CommittedState`. |
Contributor
There was a problem hiding this comment.
What? That's wacky. I'd like to see a bit more justification here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Moves stuff out of
datastore.rsandcommitted_state.rsthat has to do with replay into its own modulereplay.rs.This also shaves 64 bytes off of
CommittedStateso that we don't continue carrying the cost of replay after it has finished.This is a more limited version / part 1 of #4055 which focuses on almost pure code motion so that we're more diligent and careful about the transition. Future PRs will continue with other parts of #4055.
API and ABI breaking changes
None
Expected complexity level and risk
1, just simple and safe code motion.
Testing
Covered by existing tests as this is code motion.