Fix spacetime dev using debug builds for Rust/C# clients#4472
Closed
clockwork-labs-bot wants to merge 1 commit intomasterfrom
Closed
Fix spacetime dev using debug builds for Rust/C# clients#4472clockwork-labs-bot wants to merge 1 commit intomasterfrom
clockwork-labs-bot wants to merge 1 commit intomasterfrom
Conversation
detect_client_command() returned 'cargo run' for Rust clients and 'dotnet run' for C# clients, which default to debug builds. The server module was already built with --release, creating a mismatch. Change to 'cargo run --release' and 'dotnet run --configuration Release' so the client process matches the server module's release build. Also update for_client_lang() which generates the same commands for spacetime.json configs.
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Collaborator
|
This isn't a bug after all - the first is the module and the second is the client. It's fine as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spacetime devbuilds the server module in release mode, but the auto-detected client commands used debug builds:cargo run(debug) →cargo run --releasedotnet run(debug) →dotnet run --configuration ReleaseThis caused a build mode mismatch where the server module was optimized but the client ran unoptimized.
Updated both
detect_client_command()(auto-detection from project files) andfor_client_lang()(config-based command generation) to use release builds.