Skip to content

Fix publishing in directories with spaces#4453

Open
drogus wants to merge 1 commit intomasterfrom
drogus/fix-spaces-in-build-path
Open

Fix publishing in directories with spaces#4453
drogus wants to merge 1 commit intomasterfrom
drogus/fix-spaces-in-build-path

Conversation

@drogus
Copy link
Collaborator

@drogus drogus commented Feb 25, 2026

Description of Changes

The publish subcommand calls the build subcommand internally. The build's implementation used to split the arguments by space, which breaks when a directory contains a space.

API and ABI breaking changes

Expected complexity level and risk

1

Testing

  • Tested locally
  • Added a test

@bfops
Copy link
Collaborator

bfops commented Feb 25, 2026

The test seems to have failed?

failures:

---- subcommands::build::tests::exec_with_argstring_keeps_module_path_with_spaces_as_single_argv_item stdout ----

thread 'subcommands::build::tests::exec_with_argstring_keeps_module_path_with_spaces_as_single_argv_item' (83303) panicked at crates/cli/src/subcommands/build.rs:142:9:
assertion `left == right` failed
  left: "SpacetimeDB Projects/My SpacetimeDB App/spacetimedb"
 right: "Projects/Experiments/Simple Inventory/spacetimedb"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    subcommands::build::tests::exec_with_argstring_keeps_module_path_with_spaces_as_single_argv_item

The publish subcommand calls the build subcommand internally. The
build's implementation used to split the arguments by space, which
breaks when a directory contains a space.
@drogus drogus force-pushed the drogus/fix-spaces-in-build-path branch from 224c4ae to ac67915 Compare February 25, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants