-
Notifications
You must be signed in to change notification settings - Fork 685
spacetime.json config implementation
#4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drogus
wants to merge
73
commits into
master
Choose a base branch
from
drogus/spacetime-json
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
a5819b2
feat(cli): add client dev server support to spacetime dev
bradleyshep b7a4852
feat(cli): add client dev server support to spacetime dev
bradleyshep dde2f68
Merge branch 'feature/spacetime-dev-client-command' of https://github…
bradleyshep 6012e39
remove tomls from templates (they are generated automatically)
bradleyshep 4e429b7
Fixes
bradleyshep 02307d5
fmt
bradleyshep dfc4a08
run
bradleyshep f5ea003
spacetime config -> json
bradleyshep 947fb80
move methods into config
bradleyshep 7fe3c04
Merge branch 'master' into feature/spacetime-dev-client-command
bradleyshep 144427a
Update dev.rs
bradleyshep da2b6cb
Update spacetime_config.rs
bradleyshep 9b56f89
docs
bradleyshep d995de0
update
bradleyshep 779cfea
Merge branch 'master' into feature/spacetime-dev-client-command
bradleyshep 14528e4
Merge branch 'master' into feature/spacetime-dev-client-command
bradleyshep 97f36da
Update LLM benchmark results
clockwork-labs-bot 710fe98
Bring back eslint entries
drogus 573d323
wip
drogus 827a0b4
Cleanup
drogus 54902dc
Bring back publish after refactoring
drogus dac86be
wip
drogus b226c4a
Implement requirements in clap manually
drogus 693a7c3
Add display name for languages
drogus 0135fd2
Announce what we're doing when using config, remove debug logs
drogus 63a26e0
wip
drogus ab95f9f
Add more tests for spacetime config
drogus 5e3ebbf
Merge remote-tracking branch 'origin/feature/spacetime-dev-client-com…
drogus 7025180
Rename run to dev_run and --client-command to --dev-run
drogus e42ae5f
Merge stuff from dev_run PR into existing SpacetimeConfig
drogus 0ab69d6
Don't announce using the config file multiple times when running spac…
drogus 270a1f4
Fix spacetime.json dev-run auto-detection
drogus cae588e
Fix case when passing a filtering argument to generate/publish and no…
drogus 7aca956
Use `spacetime dev --run` and "dev": { "run": "..." }
drogus b5ba3ea
Implement spacetime.json support for spacetime dev
drogus 9d3a23c
Fixed server precedence in spacetime dev
drogus a3c50a2
Refactor CommandConfig to keep matches reference
drogus 56f1cb2
wip
drogus 581b48c
WIP
drogus 7ddbe37
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus 6f14a56
fix the build
drogus 6e4c6fa
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus f7a7a4e
Fix lints and cli reference
drogus 4557268
Fix tests
drogus 29bea9c
Lints
drogus 5417184
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus 42e1b34
Rename project-path to module-path in CLI args
drogus 3c17823
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus 86db629
Rename references to project-path to module-path
drogus 279d213
Update docs with --module-path instead of --module-project-path
drogus 5a5e584
Fix gen bindings
drogus 1d96c8b
Fix lints
drogus e3723b9
Fix build
drogus 4f73f1a
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus da3ae98
Add includ-private to config's generate
drogus 5406d75
Finish spacetime dev with spacetime.json
drogus 1f1c505
Regenerate docs
drogus 321629a
Update CLI reference
drogus 177f3e7
Fix tests
drogus 26ae014
Fix smoketests
drogus 7e390e1
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
drogus 50347d4
Fix generate and publish smoketests
drogus 2fec1a0
Improve error message for module specific args
drogus 0fdf4a1
Check for module specific args in generate
drogus bd99342
Merge remote-tracking branch 'origin/master' into drogus/spacetime-json
clockwork-labs-bot b480325
Adopt Pattern D for spacetime.json: config defines targets, CLI selec…
cloutiertyler 7a292d8
Restructure spacetime.json to database-centric model with env layering
cloutiertyler 4410b6c
Add comprehensive tests for database-centric config model
cloutiertyler 7ef25a4
Run cargo fmt
cloutiertyler 36cdc30
Fix exec_ex call in testing crate: add missing pre_loaded_config arg
cloutiertyler 7d927c1
Update docs: rename --module-name to --unreal-module-name
cloutiertyler da8dd39
Merge remote-tracking branch 'origin/master' into tyler/spacetime-jso…
cloutiertyler 68560f2
Regenerate CLI docs and revert formatting-only smoketest changes
cloutiertyler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -13,10 +13,10 @@ | |||||
| "lint": "eslint . && prettier . --check --ignore-path ../../../.prettierignore", | ||||||
| "preview": "vite preview", | ||||||
| "generate": "cargo run -p gen-bindings -- --replacement ../../../src/index && prettier --write src/module_bindings", | ||||||
| "spacetime:generate": "spacetime generate --lang typescript --out-dir src/module_bindings --project-path server", | ||||||
| "spacetime:generate": "spacetime generate --lang typescript --out-dir src/module_bindings --module-path server", | ||||||
| "spacetime:start": "spacetime start server", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "spacetime:publish:local": "spacetime publish game --project-path server --server local", | ||||||
| "spacetime:publish": "spacetime publish game --project-path server --server maincloud" | ||||||
| "spacetime:publish:local": "spacetime publish game --module-path server --server local", | ||||||
| "spacetime:publish": "spacetime publish game --module-path server --server maincloud" | ||||||
| }, | ||||||
| "dependencies": { | ||||||
| "react": "^18.3.1", | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.