fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112chriscanin wants to merge 5 commits intomainfrom
Conversation
…re TurboModuleRegistry.get pattern
🦋 Changeset detectedLatest commit: 93d8593 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the Expo NativeClerkModule specifications: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brkalow
left a comment
There was a problem hiding this comment.
did/can we verify the web case is still fixed?
tmilewski
left a comment
There was a problem hiding this comment.
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up. |
… never type errors
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |

Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit