Open
Conversation
elrayle
reviewed
Feb 15, 2024
Collaborator
elrayle
left a comment
elrayle
left a comment
There was a problem hiding this comment.
A couple of wording suggestions.
| When adding a new harvest source, the points to be considered are located at https://github.com/clearlydefined/clearlydefined/blob/master/docs/adding-sources.md#adding-a-new-harvest-source. Please include these considerations and document them in your GitHub issue, similar to https://github.com/clearlydefined/service/issues/882. | ||
|
|
||
| ## Crawler | ||
| Need to implement: |
Collaborator
There was a problem hiding this comment.
Suggested change
| Need to implement: | |
| In the crawler, each harvest source must implement fetch and extract functions. The functions are prefixed with a name that identifies the source (e.g. mavenFetch, mavenExtract). | |
| Implement: |
Co-authored-by: E. Lynette Rayle <elrayle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Add documentation for adding a new harvest source
-Ignore config files in .gitignore