Support colorscheme with only basic ANSI color sequences#63
Open
presidento wants to merge 5 commits intocknd:masterfrom
Open
Support colorscheme with only basic ANSI color sequences#63presidento wants to merge 5 commits intocknd:masterfrom
presidento wants to merge 5 commits intocknd:masterfrom
Conversation
In many terminals they can be stylized, so it can be used for solarized, dark and light terminal settings, as well.
Owner
|
Hi, sorry for the long delay and thank you for the contribution! Sounds like a great solution to the colorscheme selection problem. I also like the idea of moving more of the logic into the colorscheme objects themselves When I checked out your branch and ran demo.py with any of the old colorschemes (like darkbg), I got an error: |
Author
|
Thanks, I fixed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many terminals allow to customize the appearance. The basic colors can be overridden, but the ANSI 256 colors not.
For example, there can be solarized, light, and dark themes for the terminal having the basic colors fine-tuned for it.
(I also have to switch frequently between light and dark mode, based on the environment lightning.)