-
Notifications
You must be signed in to change notification settings - Fork 32
feat: new layer of FeePayer as a helper for transaction final completion step
#328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashuralyk
wants to merge
11
commits into
ckb-devrel:master
Choose a base branch
from
ashuralyk:feat/fee-payer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
239835a
feat: fee payer initialization
ashuralyk 7656820
feat: create a template for fee payer layer
ashuralyk 69b5e50
chore: apply fee payer manager on transaction
ashuralyk 5d1b344
chore: downgrade address related methods from Signer to SignerFeePayer
ashuralyk ed5bfe8
feat: solve cocurrence issue and doing rename
ashuralyk e796fc1
chore: rename group file
ashuralyk efa1e9e
chore: rewise spore test
ashuralyk e36515a
chore: adapt transaction test cases for new implementation
ashuralyk a524235
chore: fix data length fixed point issue and prepare dedicated test c…
ashuralyk 4c7b4cd
chore: make use of the result of prepareTransaction
ashuralyk cca8107
chore: return Transaction for mock prepareTransaction method
ashuralyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@ckb-ccc/core": patch | ||
| --- | ||
|
|
||
| Abstract transaction completion step by a new layer named FeePayer | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a minor change since it introduced new APIs.