Skip to content

only run tests workflow when needed#1332

Open
dbatten5 wants to merge 1 commit into
cjolowicz:mainfrom
dbatten5:ignore-tests-workflow
Open

only run tests workflow when needed#1332
dbatten5 wants to merge 1 commit into
cjolowicz:mainfrom
dbatten5:ignore-tests-workflow

Conversation

@dbatten5

@dbatten5 dbatten5 commented Apr 22, 2023

Copy link
Copy Markdown
  • ignore files that don't need tests, e.g. files in docs/ and .md files

closes #1328

- ignore files that don't need tests, e.g. files in `docs/` and `.md`
  files

@bosd bosd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaos-baum chaos-baum left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@bosd

bosd commented Feb 27, 2024

Copy link
Copy Markdown

@cjolowicz Can you please have a look at this? and merge 🙏

@webknjaz

Copy link
Copy Markdown

This will cause problems with branch projection rules since the expected checks will stop showing up for docs-only changes. This can be solved by having a job that determines what other jobs should run. It's done in python/cpython, pypa/pip, ansible/pylibssh to give a few examples of reference implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore the tests github action workflow if not necessary

4 participants