Skip to content

Conversation

@tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Feb 11, 2026

Add missing dir to test:integration:showcase task so mise --env tls runs from tests/ where mise.tls.toml exists, correctly loading TLS environment variables (CS_DATABASE__HOST and CS_DATABASE__PORT).

Fix quoting bug in proxy:up container detection where unquoted variable expansions collapsed multi-line docker ps output, causing grep and cut to select the wrong container when multiple postgres containers are running.

Summary by CodeRabbit

  • Tests

    • Improved integration test environment configuration with enhanced directory context and error diagnostics
    • Strengthened test execution with more robust error reporting
  • Bug Fixes

    • Fixed shell quoting issues in container detection logic
    • Corrected variable handling to prevent unintended text expansion during environment setup

Add missing dir to test:integration:showcase task so mise --env tls
runs from tests/ where mise.tls.toml exists, correctly loading TLS
environment variables (CS_DATABASE__HOST and CS_DATABASE__PORT).

Fix quoting bug in proxy:up container detection where unquoted variable
expansions collapsed multi-line docker ps output, causing grep and cut
to select the wrong container when multiple postgres containers are
running.
@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

Mise.toml updated with improved shell quoting in proxy-up logic for command substitution and diagnostic output, plus configuration additions to the showcase integration test task including directory context and Rust backtrace environment variable.

Changes

Cohort / File(s) Summary
Shell Quoting Fixes
mise.toml
Fixed unquoted grep result in Postgres container check, wrapped command substitution for host extraction in quotes, and quoted echo variable outputs to prevent unintended expansion.
Test Task Configuration
mise.toml
Added dir field to [tasks."test:integration:showcase"] pointing to config_root/tests and updated run block to include RUST_BACKTRACE=full for the showcase invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Quotes now guard our shell commands tight,
No word-splitting ruins the night,
Backtrace trails light the test's way,
A tidy config saves the day!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing a PG 17 showcase test failure by resolving issues with environment setup and container detection logic in mise.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-intermittent-tests

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@freshtonic freshtonic self-requested a review February 11, 2026 04:33
Copy link
Contributor

@freshtonic freshtonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch sir!

@tobyhede tobyhede merged commit 7cdc851 into main Feb 11, 2026
6 checks passed
@tobyhede tobyhede deleted the fix-intermittent-tests branch February 11, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants