Fix a few bugs #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off: you are doing an AMAZING work here with no praise! ❤️
I found three bugs when loading the following image: https://filesamples.com/samples/image/jp2/sample1.jp2
shortcasting):InvWTFull.cstile reconstruction:When
setTile()is called, it updates buffer dimensions, but never setsreconstructedComps[i] = nullto force reconstruction of the new tile. So all tiles after the first one keep returning data from tile (0,0).if (reconstructedComps != null && i < reconstructedComps.Length) { -// reconstructedComps[i] logic +reconstructedComps[i] = null; }J2kImage.cscopying to bitmap:We pass
bitsUsedtoInterleavedImage, which expectsbitsUsed[i]to correspond to componenti, so we can't reverse the order here.