several changes needed for updating build by Manvi-55 · Pull Request #10 · cicsdev/cics-java-liberty-springboot-transactions

Manvi-55 · 2026-04-01T09:12:32Z

No description provided.

PhilWakelin · 2026-04-07T10:48:45Z

@Manvi-55 the workflow for building the repo will need to be updated to specify only Java 17
See this as an example https://github.com/cicsdev/cics-java-liberty-springboot-jcics/blob/main/.github/workflows/java.yml

PhilWakelin

Does the web.xml need updating to Jakarta EE 10 xsd i.e.

https://jakarta.ee/xml/ns/jakartaee/web-app_6_1.xsd

PhilWakelin · 2026-04-01T10:16:51Z

-    compileOnly ("javax.transaction:javax.transaction-api")
-
+    // Java Transaction API  - don't include in the final build
+    implementation 'jakarta.transaction:jakarta.transaction-api'


Why is this implementation I think compileOnly is more suitable as the Liberty runtime should provide the JTA runtime.

PhilWakelin · 2026-04-01T10:17:46Z

    <dependency>
      <groupId>javax.transaction</groupId>
      <artifactId>javax.transaction-api</artifactId>
+      <version>1.3</version>


The javax.transaction-api dependency needs to be changed to jakarta, similar to the Gradle change.

There is no version 1.3 of jakarta.transaction-api so this doesn't build.

PhilWakelin · 2026-04-02T10:33:23Z

The CICS TS BOM should be upgraded to 6.1 to match the maven pom.xml

PhilWakelin · 2026-04-07T10:53:31Z


 ### Check dependencies

 Before building this sample, you should verify that the correct CICS TS bill of materials (BOM) is specified for your target release of CICS. The BOM specifies a consistent set of artifacts, and adds information about their scope. In the example below the version specified is compatible with CICS TS V5.5 with JCICS APAR PH25409, or newer. That is, the Java byte codes built by compiling against this version of JCICS will be compatible with later CICS TS versions and subsequent JCICS APARs. 


@Manvi-55 can you update the references here to CICS TS 5.5 to refer to CICS TS 6.1, in order to match the min prereqs.

PhilWakelin · 2026-04-07T10:55:03Z


 >Tip: *In Eclipse, Gradle (buildship) is able to fully refresh and resolve the local classpath even if the project was previously updated by Maven. However, Maven (m2e) does not currently reciprocate that capability. If you previously refreshed the project with Gradle, you'll need to manually remove the 'Project Dependencies' entry on the Java build-path of your Project Properties to avoid duplication errors when performing a Maven Project Update.*  

 #### Gradle Wrapper (command line)


@Manvi-55 In the JCICS tutorial the Gradle build instructions were changed to build not bootWar, does the same change need to be done here?

PhilWakelin · 2026-04-07T11:00:48Z


 This creates a WAR file inside the `target` directory.

 ## Deploying


@Manvi-55 Can you make this section consistent with the updated instructions in the JCICS tutorial. We currently refer to jsp-2.3 which is JEE 8, but I think we need Jakarta EE 9, the other tutorial uses servlet-6.0 which is Jakarta EE 10.

PhilWakelin · 2026-04-07T12:25:34Z

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-rc-1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip


Should we be using Gradle 8.14 here as this is the latest V8 release?

PhilWakelin · 2026-04-07T12:27:35Z

 plugins
 {
-	id 'org.springframework.boot' version '2.7.0' 
+	id 'org.springframework.boot' version '3.5.9' 


Should we upgrade to the latest release of 3.5 namely 3.5.13?

PhilWakelin · 2026-04-07T13:23:22Z

The Gradle build does not work on my win11 machine and complains about the Java toolchain. With Java 17 set as my JAVA_HOME I get

PS cics-java-liberty-springboot-transactions> .\gradlew clean build

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':bootWar'.
> Could not resolve all dependencies for configuration ':runtimeClasspath'.
   > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
      > Cannot find a Java installation on your machine matching this tasks requirements: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64.
         > No locally installed toolchains match and toolchain download repositories have not been configured.

My Java setup is:

cics-java-liberty-springboot-transactions> java -version
java version "17.0.9" 2023-10-17
IBM Semeru Runtime Certified Edition 17.0.9.0 (build 17.0.9+9)
Eclipse OpenJ9 VM 17.0.9.0 (build openj9-0.41.0, JRE 17 Windows 11 amd64-64-Bit Compressed References 20231017_542 (JIT enabled, AOT enabled)
OpenJ9   - 461bf3c70
OMR      - 5eee6ad9d
JCL      - 356287fbde7 based on jdk-17.0.9+9)

PhilWakelin · 2026-04-07T15:29:21Z

Issuing a GET to the context root for the application: i.e. http://host:port/cics-java-liberty-springboot-transactions-0.1.0 does not return the Usage Guide as documented in the README

Instead the browser returns:

Error 404: No static resource

PhilWakelin · 2026-04-08T09:52:21Z

Issuing a GET to the context root for the application: i.e. http://host:port/cics-java-liberty-springboot-transactions-0.1.0 does not return the Usage Guide as documented in the README

Instead the browser returns:

Error 404: No static resource

I had a look at the TransactionController Class and it has a mapping for the "/" URL, so the trailing slash is required to obtain the Usage Guide. So I think the usage instructions just need updating to cover this.

initial

23ccf08

Manvi-55 requested a review from PhilWakelin April 1, 2026 09:12

Manvi-55 self-assigned this Apr 1, 2026

Manvi-55 requested a review from IvanHargreaves April 1, 2026 09:13

manvisingh55 added 4 commits April 2, 2026 14:55

java to jakarta edit

308c610

cics bom version update and jakarta version removal

3cc81b8

cics ts bom update

a5c457d

readme version updated

e799d13

PhilWakelin reviewed Apr 7, 2026

View reviewed changes

Manvi-55 requested a review from PhilWakelin April 10, 2026 09:44

web.xml and java.yml changes

779fa89


		### Check dependencies

		Before building this sample, you should verify that the correct CICS TS bill of materials (BOM) is specified for your target release of CICS. The BOM specifies a consistent set of artifacts, and adds information about their scope. In the example below the version specified is compatible with CICS TS V5.5 with JCICS APAR PH25409, or newer. That is, the Java byte codes built by compiling against this version of JCICS will be compatible with later CICS TS versions and subsequent JCICS APARs.


		>Tip: In Eclipse, Gradle (buildship) is able to fully refresh and resolve the local classpath even if the project was previously updated by Maven. However, Maven (m2e) does not currently reciprocate that capability. If you previously refreshed the project with Gradle, you'll need to manually remove the 'Project Dependencies' entry on the Java build-path of your Project Properties to avoid duplication errors when performing a Maven Project Update.

		#### Gradle Wrapper (command line)


		This creates a WAR file inside the `target` directory.

		## Deploying

Conversation

Manvi-55 commented Apr 1, 2026

Uh oh!

PhilWakelin commented Apr 7, 2026

Uh oh!

PhilWakelin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PhilWakelin Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PhilWakelin commented Apr 7, 2026

Uh oh!

PhilWakelin commented Apr 7, 2026

Uh oh!

PhilWakelin commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PhilWakelin Apr 7, 2026 •

edited

Loading