Skip to content

build: switch to pyproject.toml#440

Draft
afuetterer wants to merge 7 commits intochrismattmann:masterfrom
afuetterer:toml
Draft

build: switch to pyproject.toml#440
afuetterer wants to merge 7 commits intochrismattmann:masterfrom
afuetterer:toml

Conversation

@afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Feb 22, 2026

Hi, since you merged my PR about the gha setup, I thought I might submit another one.

This modernizes the project setup using a pyproject.toml file.

What do you think?

Refs:

Tasks

@afuetterer

This comment was marked as outdated.

@afuetterer afuetterer marked this pull request as ready for review February 23, 2026 09:19
@afuetterer

This comment was marked as resolved.

@chrismattmann
Copy link
Owner

If this PR looks good to you, I will squash all those tiny commits.

LGTM please squash.

@afuetterer afuetterer marked this pull request as draft February 24, 2026 08:29
@afuetterer afuetterer force-pushed the toml branch 2 times, most recently from 5b27c5e to 707db94 Compare March 4, 2026 05:47
@afuetterer afuetterer marked this pull request as ready for review March 4, 2026 05:47
@coveralls
Copy link

coveralls commented Mar 4, 2026

Coverage Status

coverage: 55.646% (+2.2%) from 53.469%
when pulling 66aae33 on afuetterer:toml
into ce4c3ca on chrismattmann:master.

@afuetterer afuetterer marked this pull request as draft March 4, 2026 06:00
@afuetterer
Copy link
Contributor Author

Failing test case due to network reasons.

@chrismattmann
Copy link
Owner

Failing test case due to network reasons.

Do we need the failing test to be fixed first? Looks like it's tied to a specific Python version @afuetterer

@afuetterer
Copy link
Contributor Author

I don't think it depends on the Python version.

It is about reaching http://neverssl.com/index.html (port 80 without ssl), that results in an error. Maybe because I introduced verify_ssl in the new _urlretrieve function. But it worked during that PR, which confuses me.

@chrismattmann
Copy link
Owner

I don't think it depends on the Python version.

It is about reaching http://neverssl.com/index.html (port 80 without ssl), that results in an error. Maybe because I introduced verify_ssl in the new _urlretrieve function. But it worked during that PR, which confuses me.

OK interesting. We should probably make sure the build passes on that version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants