Allow card pages to animate in from any edge#46
Open
alexhardwicke wants to merge 1 commit intochrfalch:developfrom
Open
Allow card pages to animate in from any edge#46alexhardwicke wants to merge 1 commit intochrfalch:developfrom
alexhardwicke wants to merge 1 commit intochrfalch:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add support for animating in the card page from any edge (when using page.ShowAsync()).
This is an initial pull request to start a discussion about how to handle a few things - I don't think it's yet ready to merge in, although functionally it works perfectly.
The main question I have is regarding the "CardPosition" enum and property that @vbenkevich added with #1.
We could use CardPosition for the animation edge rather than adding a new property (which is what I've done at the moment), but if we did that I'm not sure how to handle Custom and Center.
They also have two different purposes, as far as I can tell - CardPosition is where the card is anchored when it's fully animated in, while my new "EdgePosition" is the edge it should animate from when it's appearing.