Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 28, 2025

Implementation Plan for %-30s Format Support

  • Analyze the current Dmod_VSnPrintf_Impl implementation in dmod_prf.c
  • Add support for parsing width specifier (e.g., 30 in %-30s)
  • Add support for parsing alignment flag (e.g., - for left-align in %-30s)
  • Modify Dmod_Print_String to handle width and alignment for strings
  • Write comprehensive tests for the new functionality
  • Build and test the changes
  • Verify the fix with the example from the issue
  • Address code review feedback:
    • Fixed negative padding length handling
    • Added overflow protection for width parsing (max 1024)
  • Final security review
Original prompt

This section details on the original issue you should resolve

<issue_title>Dmod_SnPrintf nie wspiera %-30s</issue_title>
<issue_description>Trzeba dodać wsparcie dla tego tagu, aby to działało:

stm32f746xg@/> module list
Available modules:
%-30s %-15s %-40s
---------------------------------------------------------------------------------------------
%-30s %-15s %-40s
%-30s %-15s %-40s
%-30s %-15s %-40s
%-30s %-15s %-40s
%-30s %-15s %-40s
%-[B[B[B[B[B[B[B[B[B[B[B[B[B[B

```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 28, 2025
Copilot AI and others added 2 commits December 28, 2025 16:37
…mat)

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis marked this pull request as ready for review December 28, 2025 16:40
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
@JohnAmadis JohnAmadis merged commit 3c9a834 into develop Dec 28, 2025
4 checks passed
Copilot AI requested a review from JohnAmadis December 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dmod_SnPrintf nie wspiera %-30s

2 participants