Skip to content

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Jan 8, 2026

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)

Resolves #

What is the current behavior? (You can also link to an open issue here)

intersphinx inventory has moved: https://towncrier.rtfd.io/en/latest/objects.inv -> https://towncrier.readthedocs.io/en/latest/objects.inv
intersphinx inventory has moved: https://cherrypy.rtfd.io/en/latest -> https://docs.cherrypy.dev/en/latest/

What is the new behavior (if this is a feature change)?
No warnings

📋 Other information:

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.19%. Comparing base (662cd9d) to head (abf6ec9).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   78.38%   78.19%   -0.19%     
==========================================
  Files          41       41              
  Lines        4788     4788              
  Branches      547      547              
==========================================
- Hits         3753     3744       -9     
- Misses        896      905       +9     
  Partials      139      139              

@mr-c

This comment was marked as outdated.

@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from 7f9b261 to 3442a36 Compare January 8, 2026 12:33
@mr-c mr-c changed the title docs: adjust intersphinx links docs: adjust intersphinx links & fix build for Python 3.14 Jan 8, 2026
@mr-c mr-c changed the title docs: adjust intersphinx links & fix build for Python 3.14 docs: adjust intersphinx links & fix building docs with Python 3.14 Jan 8, 2026
@webknjaz
Copy link
Member

webknjaz commented Jan 8, 2026

Thanks for the PR! I may be slow to review (trying to limit my GH exposure due to health issues). But I think I've made the main notes I wanted to relay inline.

The linkcheck is broken due to tidelift moving the picture, it seems. So that's unrelated and shouldn't be fixed in this PR. I'll force-merge when needed.

@webknjaz webknjaz moved this to 🧐 @webknjaz's review queue 📋 in 📅 Procrastinating in public 😵‍💫 Jan 8, 2026
@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from 0ec1642 to 969fd35 Compare January 9, 2026 14:31
@mr-c
Copy link
Contributor Author

mr-c commented Jan 9, 2026

Thank for the review @webknjaz ; I've incorporated all of your suggestions and I think this PR is ready for merging.

@julianz-
Copy link
Member

julianz- commented Feb 6, 2026

Hi @mr-c. @webknjaz has asked me to help. Can I suggest some very slight changes to your PR description to clean up a couple of typos and for clarity?

  1. CherryPy documentation indirection (intersphinx fallback URLs) is no longer needed as of cherrypy.org domain squatted post Webfaction merging cherrypy#1872.
  2. sphinx-tabs is not yet compatible with docutils 0.22, so that is now disallowed.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianz- you should be able to push to the PR-bound branches when the contributors keep the respective checkbox ticked, FYI.

@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from 969fd35 to 1fe3f9b Compare February 8, 2026 10:30
cherrypy indirection in no longer neeeded as of
cherrypy/cherrypy#1872 (comment)
@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from 1fe3f9b to e984f9c Compare February 8, 2026 10:39
@mr-c
Copy link
Contributor Author

mr-c commented Feb 8, 2026

Thanks for the review, I've applied all the suggestions!

Copy link
Member

@julianz- julianz- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thanks @mr-c

@webknjaz
Copy link
Member

webknjaz commented Feb 9, 2026

@julianz- I've left instructions for fixing the docs build: #812

@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from e984f9c to f653e34 Compare February 9, 2026 15:37
@mr-c mr-c force-pushed the docs_fix_intersphinx_redirect branch from f653e34 to abf6ec9 Compare February 9, 2026 15:37
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll force-merge so you don't have to wait for #812 to be solved.

@github-project-automation github-project-automation bot moved this from 🧐 @webknjaz's review queue 📋 to ⏰ Merge reminder needed 🔀 in 📅 Procrastinating in public 😵‍💫 Feb 9, 2026
@webknjaz webknjaz merged commit 51b7d62 into cherrypy:main Feb 9, 2026
70 of 76 checks passed
@github-project-automation github-project-automation bot moved this from ⏰ Merge reminder needed 🔀 to 🌈 Done 🦄 in 📅 Procrastinating in public 😵‍💫 Feb 9, 2026
@mr-c mr-c deleted the docs_fix_intersphinx_redirect branch February 9, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants