-
-
Notifications
You must be signed in to change notification settings - Fork 99
docs: adjust intersphinx links & fix building docs with Python 3.14 #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 78.38% 78.19% -0.19%
==========================================
Files 41 41
Lines 4788 4788
Branches 547 547
==========================================
- Hits 3753 3744 -9
- Misses 896 905 +9
Partials 139 139 |
This comment was marked as outdated.
This comment was marked as outdated.
7f9b261 to
3442a36
Compare
|
Thanks for the PR! I may be slow to review (trying to limit my GH exposure due to health issues). But I think I've made the main notes I wanted to relay inline. The linkcheck is broken due to tidelift moving the picture, it seems. So that's unrelated and shouldn't be fixed in this PR. I'll force-merge when needed. |
0ec1642 to
969fd35
Compare
|
Thank for the review @webknjaz ; I've incorporated all of your suggestions and I think this PR is ready for merging. |
|
Hi @mr-c. @webknjaz has asked me to help. Can I suggest some very slight changes to your PR description to clean up a couple of typos and for clarity?
|
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julianz- you should be able to push to the PR-bound branches when the contributors keep the respective checkbox ticked, FYI.
969fd35 to
1fe3f9b
Compare
cherrypy indirection in no longer neeeded as of cherrypy/cherrypy#1872 (comment)
1fe3f9b to
e984f9c
Compare
|
Thanks for the review, I've applied all the suggestions! |
julianz-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Thanks @mr-c
e984f9c to
f653e34
Compare
There is a pending fix upstream at executablebooks/sphinx-tabs#207
f653e34 to
abf6ec9
Compare
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll force-merge so you don't have to wait for #812 to be solved.
:pypi:`docutils`to before 0.22 for documentation builds so that the:pypi:`sphinx-tabs`plugin remains compatible.❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)Resolves #
❓ What is the current behavior? (You can also link to an open issue here)
❓ What is the new behavior (if this is a feature change)?
No warnings
📋 Other information:
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences