Respond 400 instead of 500 when first header field line starts with SP or HTAB#729
Open
kenballus wants to merge 3 commits intocherrypy:mainfrom
Open
Respond 400 instead of 500 when first header field line starts with SP or HTAB#729kenballus wants to merge 3 commits intocherrypy:mainfrom
kenballus wants to merge 3 commits intocherrypy:mainfrom
Conversation
kenballus
force-pushed
the
main
branch
2 times, most recently
from
bd642f1 to
3fa1439
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 83.65% 83.67% +0.02%
==========================================
Files 28 28
Lines 4166 4178 +12
==========================================
+ Hits 3485 3496 +11
- Misses 681 682 +1 |
kenballus
force-pushed
the
main
branch
2 times, most recently
from
94d81bb to
6778ce9
Compare
Prevent unhandled exception in header parsing that results in 500 responses when the first received header begins with whitespace.
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "Bad chunked transfer size: {chunk_size!r}".format( | ||
| chunk_size=chunk_size | ||
| 'Bad chunked transfer size: {chunk_size!r}'.format( | ||
| chunk_size=chunk_size, |
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
| r"https://github\.com" | ||
| r"/python/cpython/blob/c39b52f/Lib/poplib\.py#user-content-L297-L302", | ||
| r"^https://matrix\.to/#", # these render fully on front-end from anchors | ||
| r'https://github\.com' r'/python/cpython/blob/c39b52f/Lib/poplib\.py#L297-L302', |
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning documentation
Comment on lines
+124
to
+125
| r'https://github\.com' | ||
| r'/python/cpython/blob/c39b52f/Lib/poplib\.py#user-content-L297-L302', |
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)#728
❓ What is the current behavior? (You can also link to an open issue here)
Cheroot responds 500 when it receives a request in which the first header field line starts with SP or HTAB, due to an
UnboundLocalError.❓ What is the new behavior (if this is a feature change)?
It responds 400 instead.
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is