Open
Conversation
sujaya-sys
changed the title
sorccu
requested changes
Feb 18, 2026
| | `hostname` | `string` | ✅ | - | The target host (domain name or IP address) | | ||
| | `pingCount` | `number` | ❌ | `10` | Number of ICMP Echo Request packets to send per check run (1-50, default: 10) | | ||
| | `assertions` | `IcmpAssertion[]` | ❌ | `[]` | Response assertions using the `IcmpAssertionBuilder` | | ||
| | `ipFamily` | `string` | ❌ | `IPv4` | IP family selection (Ipv4, Ipv6) | |
Member
There was a problem hiding this comment.
You should use the proper casing for the available values because it matters (IPv4 and IPv6).
| ```ts | ||
| IcmpAssertionBuilder.jsonResponse('$.packetLoss').lessThan(10) | ||
| // Equivalent to: | ||
| { source: 'JSON_RESPONSE', property: '$.packetLoss', comparison: 'LESS_THAN', target: '10' } |
Member
There was a problem hiding this comment.
I would use a different field like packetsReceived in the example.
Member
There was a problem hiding this comment.
Also we should have the full schema available somewhere. Don't use the CLI's comments as a reference for that btw - I am not completely sure whether it is accurate. If you find a discrepancy, let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components