Skip to content

fix: guard against invalid versions in package.json when checking playwright version #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwartig merged 1 commit into from
Feb 20, 2026
Merged

fix: guard against invalid versions in package.json when checking playwright version #1232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/cli/src/services/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,13 @@ export async function getPlaywrightVersionFromPackage (cwd: string): Promise<str
const range =
packageJson.dependencies?.['@playwright/test']
?? packageJson.devDependencies?.['@playwright/test']
if (range && !semver.satisfies(version, range)) {

if (!range) {
return version
}

const validRange = semver.validRange(range)
if (validRange && !semver.satisfies(version, validRange)) {
throw new Error(
`Installed @playwright/test version ${version} does not satisfy the required range "${range}" in package.json. `
+ 'Please run your package manager\'s install command to sync node_modules.',
Expand Down