Conversation
…st version The version of @playwright/test in node_modules might be out of sync with what is required in package.json/package-lock.json. In those rare cases the cli will report an incorrect playwright version to the API which will cause checks to fail as checks rely on the playwright version noted in lock files.
sorccu
approved these changes
Feb 20, 2026
sorccu
reviewed
Feb 20, 2026
| const range = | ||
| packageJson.dependencies?.['@playwright/test'] | ||
| ?? packageJson.devDependencies?.['@playwright/test'] | ||
| if (range && !semver.satisfies(version, range)) { |
Member
There was a problem hiding this comment.
I know I already approved the PR and unfortunately you already merged, but I had a late suggestion. There is a possibility that the range is not valid. For example it could point to a local copy of the package or be something like "catalog:" w/ pnpm. For invalid ranges, satisfies() just returns false so they'll always hit this error. We should probably do this instead:
if (range) {
const validRange = semver.validRange(range)
if (validRange && !semver.satisfies(version, validRange)) {
// throw
// ...
Contributor
Author
There was a problem hiding this comment.
Ahhrg right. good catch, I'll prep the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of @playwright/test in node_modules might be out of sync with what is required in package.json/package-lock.json. In those rare cases the cli will report an incorrect playwright version to the API which will cause checks to fail as checks rely on the playwright version noted in lock files.
Affected Components