feat: enhance CSS parsing and unit handling #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobPritchett
commented
Dec 7, 2025
BobPritchett
commented
- Added support for additional CSS escape sequences (b, f, j, q, v, w, y) in parse-css.pegjs.
- Updated Length type in style.ts to include new units (cm, mm, Q, in, pc, pt, px, em).
- Refactored resolveEm function to resolveUnit for better unit conversion handling.
- Improved unit conversion logic for various length units in resolveUnit function.
- Added VSCode launch configuration for debugging Vite applications in Chrome and Edge.
- Created VSCode settings to disable format on save and Prettier.
- Added support for additional CSS escape sequences (b, f, j, q, v, w, y) in parse-css.pegjs. - Updated Length type in style.ts to include new units (cm, mm, Q, in, pc, pt, px, em). - Refactored resolveEm function to resolveUnit for better unit conversion handling. - Improved unit conversion logic for various length units in resolveUnit function. - Added VSCode launch configuration for debugging Vite applications in Chrome and Edge. - Created VSCode settings to disable format on save and Prettier.
chearon
reviewed
Dec 11, 2025
Owner
chearon
left a comment
chearon
left a comment
There was a problem hiding this comment.
The biggest thing is that several tests are failing. I'll figure out how to get the tests to run when your PR is opened. Not sure what the problem is; where you put resolveUnit should be alright.
src/parse-css.pegjs
Outdated
| W = 'w'i / '\\' '0'? '0'? '0'? '0'? [\x57\x77] ('\r\n' / [ \t\r\n\f])? / '\\w'i { return 'w'; } | ||
| X = 'x'i / '\\' '0'? '0'? '0'? '0'? [\x58\x78] ('\r\n' / [ \t\r\n\f])? / '\\x'i { return 'x'; } | ||
| Y = 'y'i / '\\' '0'? '0'? '0'? '0'? [\x59\x79] ('\r\n' / [ \t\r\n\f])? / '\\y'i { return 'y'; } | ||
| Z = 'z'i / '\\' '0'? '0'? '0'? '0'? [\x5A\x7A] ('\r\n' / [ \t\r\n\f])? / '\\z'i { return 'z'; } |
Owner
There was a problem hiding this comment.
I don't think most of the additions here are used. Can you remove the other changes, so it just adds Q?
If you look at the pegjs output, this actually does cause dead code to be generated.
Author
There was a problem hiding this comment.
I can, but I think it very likely we'll need some/all of them and having it be complete now seemed likely a way to reduce errors in the future. Maybe commenting them out till used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.