Skip to content

feat: remove /metrics from the website#703

Merged
missytake merged 1 commit intomainfrom
link2xt/remove-metrics
Mar 5, 2026
Merged

feat: remove /metrics from the website#703
missytake merged 1 commit intomainfrom
link2xt/remove-metrics

Conversation

@link2xt
Copy link
Copy Markdown
Contributor

@link2xt link2xt commented Oct 29, 2025

Similar data is already generated by fsreport
available for the relay operator
and metrics for prometheus are generated by mtail.

Closes #431

@link2xt link2xt force-pushed the link2xt/remove-metrics branch from 215a9df to 84d461f Compare October 29, 2025 12:15
Copy link
Copy Markdown
Collaborator

@cliffmccarthy cliffmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and appeals to my "negative lines of code" sense.

@link2xt link2xt force-pushed the link2xt/remove-metrics branch from 84d461f to a933411 Compare October 31, 2025 07:26
@link2xt link2xt mentioned this pull request Oct 31, 2025
@ccclxxiii
Copy link
Copy Markdown
Collaborator

@link2xt this was a point of confusion for some relay operators, glad it's being factored away. the mtail works quite well as it is.

@feld
Copy link
Copy Markdown
Collaborator

feld commented Dec 8, 2025

fsreport doesn't tell you how many accounts, only login stats. But it would be easy to update fsreport to add it.

@link2xt link2xt force-pushed the link2xt/remove-metrics branch from a933411 to a27adb1 Compare January 5, 2026 17:25
@link2xt link2xt temporarily deployed to staging.chatmail.at/doc/relay/ January 5, 2026 17:25 — with GitHub Actions Inactive
@link2xt link2xt temporarily deployed to staging2.testrun.org January 5, 2026 17:25 — with GitHub Actions Inactive
@link2xt link2xt temporarily deployed to staging-ipv4.testrun.org January 5, 2026 17:25 — with GitHub Actions Inactive
@link2xt link2xt force-pushed the link2xt/remove-metrics branch from a27adb1 to 3381424 Compare January 5, 2026 17:25
@link2xt link2xt temporarily deployed to staging.chatmail.at/doc/relay/ January 5, 2026 17:25 — with GitHub Actions Inactive
@link2xt link2xt had a problem deploying to staging-ipv4.testrun.org January 5, 2026 17:25 — with GitHub Actions Error
@link2xt link2xt had a problem deploying to staging2.testrun.org January 5, 2026 17:25 — with GitHub Actions Error
@link2xt link2xt changed the title Remove /metrics from the website feat: remove /metrics from the website Jan 5, 2026
@link2xt link2xt force-pushed the link2xt/remove-metrics branch from 3381424 to b4a027d Compare January 5, 2026 17:33
@link2xt link2xt temporarily deployed to staging.chatmail.at/doc/relay/ January 5, 2026 17:33 — with GitHub Actions Inactive
@link2xt link2xt temporarily deployed to staging2.testrun.org January 5, 2026 17:33 — with GitHub Actions Inactive
@link2xt link2xt temporarily deployed to staging-ipv4.testrun.org January 5, 2026 17:33 — with GitHub Actions Inactive
@link2xt
Copy link
Copy Markdown
Contributor Author

link2xt commented Jan 5, 2026

this was a point of confusion for some relay operators, glad it's being factored away

This was brought up on the forum again: https://support.delta.chat/t/userbase-information/4567/4

So rebasing it.

@feld
Copy link
Copy Markdown
Collaborator

feld commented Jan 14, 2026

in the spirit of reducing unnecessary external metadata, let's just do this if there aren't any blockers

@j4n
Copy link
Copy Markdown
Contributor

j4n commented Jan 14, 2026

I just stumbled across this today; but it did not seem the metrics where equivalent to the ones from mtail:

# HELP total number of accounts
# TYPE accounts gauge
accounts 12830
# HELP number of CI accounts
# TYPE ci_accounts gauge
ci_accounts 0
# HELP number of non-CI accounts
# TYPE nonci_accounts gauge
nonci_accounts 12830

vs mtail

# HELP created_accounts defined at delivered_mail.mtail:17:9-24
# TYPE created_accounts counterd_mail.mtail"} 41444
created_accounts{prog="delivered_mail.mtail"} 41444l.mtail:18:9-27
# HELP created_ci_accounts defined at delivered_mail.mtail:18:9-27
# TYPE created_ci_accounts counterd_mail.mtail"} 0
created_ci_accounts{prog="delivered_mail.mtail"} 0_mail.mtail:19:9-30
# HELP created_nonci_accounts defined at delivered_mail.mtail:19:9-30
# TYPE created_nonci_accounts counterd_mail.mtail"} 41444
created_nonci_accounts{prog="delivered_mail.mtail"} 41444-22
# HELP delivered_mail defined at delivered_mail.mtail:1:9-22

(and there seems to be something weird going on with that mtail output)

Maybe we should just output the metrics to /var/lib/prometheus/node-exporter instead of /var/www/?

@link2xt
Copy link
Copy Markdown
Contributor Author

link2xt commented Jan 15, 2026

Don't know why your output looks like this, something is probably wrong with the terminal. created_accounts metric is a counter since the start of mtail as it gets the info from logs, so you can use it to see how many accounts are created in some timespan by recording this in prometheus.

@j4n
Copy link
Copy Markdown
Contributor

j4n commented Jan 15, 2026

I understand, mtail is providing the rate of account creation; I think it would be helpful to be able to monitor total accounts on the relay continuing removal of the public /metric.

Incorporating it into fsreport would be sensible I suppose, ideally with openmetrics-compatible output. If I understand correctly, fsreport is already running by systemd-timer regularly?

Re output, I indeed can't reproduce this issue atm.

@hpk42
Copy link
Copy Markdown
Contributor

hpk42 commented Jan 16, 2026 via email

@missytake missytake force-pushed the link2xt/remove-metrics branch from d9e0f3a to 3b852b0 Compare January 17, 2026 19:59
@link2xt
Copy link
Copy Markdown
Contributor Author

link2xt commented Jan 17, 2026

Why do we want to expose the number of addresses to everyone on the internet? What is the usecase for knowing the number of addresses on servers that are not run by you?

@j4n
Copy link
Copy Markdown
Contributor

j4n commented Mar 4, 2026

I just pushed #881 which would allow us to remove metrics.py and still provide monitoring output for those who want it.

@missytake
Copy link
Copy Markdown
Contributor

Why do we want to expose the number of addresses to everyone on the internet? What is the usecase for knowing the number of addresses on servers that are not run by you?

by now, I agree :)

@j4n j4n closed this in #881 Mar 5, 2026
@j4n j4n reopened this Mar 5, 2026
Similar data is already generated by fsreport
available for the relay operator
and metrics for prometheus are generated by mtail.

Closes <#431>
@j4n
Copy link
Copy Markdown
Contributor

j4n commented Mar 5, 2026

rebased, and I think we can merge this, the only question is if we should amend the systemd-unit for fsreport to output the metrics file (#881 now merged) to keep the user count public.

Copy link
Copy Markdown
Contributor

@missytake missytake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) I had arguments against it before which are now gone

Copy link
Copy Markdown
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's remove it.

@missytake missytake merged commit 7743507 into main Mar 5, 2026
7 checks passed
@missytake missytake deleted the link2xt/remove-metrics branch March 5, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove /metrics

7 participants