fix: Handle the case that the user starts a securejoin, and then deletes the contact#7883
Open
Hocuri wants to merge 1 commit intohoc/securejoin-v3from
Open
fix: Handle the case that the user starts a securejoin, and then deletes the contact#7883Hocuri wants to merge 1 commit intohoc/securejoin-v3from
Hocuri wants to merge 1 commit intohoc/securejoin-v3from
Conversation
Hocuri
changed the title
Hocuri
force-pushed
the
hoc/allow-securejoin-if-contact-was-deleted
branch
from
9e20577 to
747ca5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7880
depends on #7754
With this change, a securejoin message is just ignored if the contact was deleted in the meantime; apparently the user is not interested in the securejoin process anymore if they deleted the contact.
But other, parallel securejoin processes must not be affected; the test also tests this.