Feature/waterfall chart sample#12253
Open
BrunoDuvane40 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #12152 by adding Waterfall chart examples to the Chart.js documentation samples.
The contribution focuses on documentation/sample enhancement and demonstrates two different ways to create Waterfall charts using existing Chart.js bar chart functionality.
Interactive demo:
https://codepen.io/BrunoDuvane40/pen/pvNEPPB
Changes Made
docs/samples/bar/waterfall.mddocs/samples/bar/waterfall-stacked.mddocs/.vuepress/config.tsto register the new samples under the “Bar Charts” sectionImplementation Notes
Two alternative approaches were implemented and documented:
[start, end]values to directly represent cumulative transitionsAlternative approaches considered:
[start, end]rangesThe floating bar implementation was considered the cleaner and more semantically direct solution because each Waterfall step explicitly represents its visual start and end values without requiring auxiliary transparent datasets.
The stacked bar approach was also included because it aligns closely with the implementation idea discussed in the original issue.
Testing / Verification
pnpm run buildNODE_OPTIONS=--openssl-legacy-provider pnpm run docs:devRelated Issue
Closes #12152