Add initial support to represent diagrams with Mermaid#89
Open
dplanella wants to merge 1 commit intochaoss:masterfrom
Open
Add initial support to represent diagrams with Mermaid#89dplanella wants to merge 1 commit intochaoss:masterfrom
dplanella wants to merge 1 commit intochaoss:masterfrom
Conversation
Signed-off-by: David Planella <dplanella@gitlab.com>
Member
|
Pretty cool. I need to play with mermaid to understand its full capabilities. Thanks @dplanella |
Member
|
-1 , I would prefer to replace the diagrams with artworks (pngs files derived from svg ones) as proposed at: #6 |
Contributor
Author
|
Thanks for the reviews. The ideas behind it were to ultimately lower the barrier for contribution, as:
|
Contributor
Author
|
@acs @valeriocos @jgbarah any further thoughts on this PR? Thanks. |
Member
|
I'm fine with any decision @dplanella :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating diagrams with Mermaid for easier maintenance and for lowering the barrier to documentation contributions.
Notes:
graph LRline bygraph TD