Conversation
Signed-off-by: Christine Belzie <shecoder30@gmail.com>
Signed-off-by: Christine Belzie <shecoder30@gmail.com>
Signed-off-by: Christine Belzie <shecoder30@gmail.com>
GeorgLink
left a comment
GeorgLink
left a comment
There was a problem hiding this comment.
Thanks for starting the work on this.
I suggest keeping the PRs small and only changing a few screenshots at a time. This helps with reviewing the work and getting it merged.
I commented on the changes with some concerns. Can you please check and let me know what solution you suggest?
There was a problem hiding this comment.
The name of the new file is different from the old file. When changing file names, the references in the document also need to be updated. It may be easier to keep the same file name
There was a problem hiding this comment.
What are your thoughts on preserving the size of the image when updating? I haven't checked where the image appears in the tutorial and whether a larger size will effect the display in the tutorial.
The original screenshot did not have the red and blue boxes painted on it - I suggest not adding them in the updated screenshots.
There was a problem hiding this comment.
The new image does not show for me.
|
I suggest to not close automatically chaoss/grimoirelab#604 -- I think it better to have many smaller PRs and only close the issue when the handbook is fully updated. |
We can always reopen it after the PR merges @GeorgLink |
2 participants
Description of change
This PR fixes a typo and updates the tutorial's screenshots.
Benefits
Ensures information is accurate
Issue
Closes #604
Note to Reviewers
This PR is still a WIP.